-
Notifications
You must be signed in to change notification settings - Fork 31.9k
add option for input validation foreground color #57734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option for input validation foreground color #57734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParkourKarthik unless I am mistaken, these colors should not have any default set, otherwise we change the semantics, aren't we? Today I do not think we apply any particular foreground color by default and I think we should only do so if the theme defines this color explicitly.
Also, we need to support this color everywhere where the correlating background color is passed through, so please find all occurrences of where input background colors are used and pass them through.
@bpasero I've set the default values to Note: I've not added any Validation Foreground colors to the below as there should not be defaults for Foreground. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParkourKarthik much better. There is one remaining usage of inputValidationInfoBackground
in messageController
that can also have a foreground color from the theme.
Thanks 🍺 |
This closes #57536
@bpasero I've made changes only related to "find Input control".
Review and let me know if similar changes could be applied to all other input validations.