Add tooltips to extension navbar #49825
Conversation
| const run = () => this._update(id); | ||
| const action = new Action(id, label, null, true, run); | ||
|
|
||
| if (!action.tooltip) { |
There was a problem hiding this comment.
I do not think you need to check for existing tooltip. You can set it to given tooltip always
There was a problem hiding this comment.
You're right. No need for that then :)
What do you think of the captions as
Details -> Extension details
Contributions -> Extension contributions to VS Code editor
Changelog -> Extension changelog
Dependencies -> Extension dependencies
Got a comment and suggestions in #47586 about them being a bit "automatically generated" wich I guess is true. But they're also informative, which was the issue to begin with.
Thoughts?
There was a problem hiding this comment.
Tooltips can be informative.. I think it makes sense to accept the suggestions from there.
|
Check for existing tooltip is removed. Captions changed to: |
|
LGTM Thanks @InspectorDeno |
Adds clarity to the extension details by adding tooltips, as mentioned in #47586.
