Skip to content

Refactor: Remove useless event interface #49684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from May 14, 2018
Merged

Refactor: Remove useless event interface #49684

merged 1 commit into from May 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2018

Change logs:

1) /vscode/src/vs/platform/jsonschemas/common/jsonContributionRegistry.ts:Remove interface IJSONContributionRegistryEvent.

Why?

This event was created in 2015, and it's never referred by any other modules, functions……ect, when you are looking for its references in Visual Studio Code.

@aeschli aeschli merged commit 2fd0f20 into microsoft:master May 14, 2018
@aeschli
Copy link
Contributor

aeschli commented May 14, 2018

Thanks @MaleDong !

@aeschli aeschli added this to the May 2018 milestone May 14, 2018
@aeschli aeschli added verified Verification succeeded bug Issue identified by VS Code Team member as probable bug labels May 29, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant