Highlight escaped characters in default Light+ (Fix #48638) #48746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #48638


Before
After
These issue is cause of
string
andconstant.character.escape
is same(#a31515
).This new color(
#800000
) looks not so changed. I referenced dark-themehttps://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/themes/dark_plus.json#L159
use same color from
https://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/themes/dark_vs.json#L90
and
https://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/themes/dark_vs.json#L164
So this
#800000
is used fromhttps://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/themes/light_vs.json#L88
and
https://github.com/Microsoft/vscode/blob/master/extensions/theme-defaults/themes/light_vs.json#L66