Skip to content

Highlight escaped characters in default Light+ (Fix #48638) #48746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2018

Conversation

@mjbvz mjbvz self-requested a review April 27, 2018 20:31
@mjbvz mjbvz assigned mjbvz and unassigned aeschli Apr 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 27, 2018

Code change looks good but the color is too low contrast. What about #ff0000 which is used by the light theme for regular expressions?

@Ikuyadeu
Copy link
Contributor Author

Ikuyadeu commented Apr 28, 2018

@mjbvz Thank you for review!
I fixed to #ff0000 that from keyword.operator.or.regexp and keyword.control.anchor.regexp

screen shot 2018-04-28 at 17 37 37

However, #000000 that from keyword.operator.quantifier.regexp is also good contrast and it is same usage of default dark theme. Which is good for you?
screen shot 2018-04-28 at 17 37 18

Ps. Sorry I committed wrong version too, so I pushed one fixed commit too.

@mjbvz mjbvz merged commit 11834f3 into microsoft:master Apr 29, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 29, 2018

Thanks. If anyone complains about the bright red color, we can switch it to black as you suggest.

It's too late to put this change in the upcoming VS Code 1.23 release, but it will be in May VS Code release: 1.24

@mjbvz mjbvz added this to the May 2018 milestone Apr 29, 2018
@Ikuyadeu Ikuyadeu deleted the fix_light_theme branch April 30, 2018 05:56
@Ikuyadeu
Copy link
Contributor Author

@mjbvz OK, thank you for merge.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: highlight escaped javascript characters in default Light+ theme
3 participants