Skip to content

Revert - move striping logic back to javascript for running extensions #42022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Revert - move striping logic back to javascript for running extensions #42022

merged 1 commit into from
Jan 23, 2018

Conversation

usernamehw
Copy link
Contributor

I haven't had a list long enough to test it on OSS Dev, so...
When you scroll down and then up (or vice versa) you'll get 2 consecutive rows with the same color:
running_extensions

cc @isidorn

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2018

@usernamehw great catch. The issue is that the list is virtualised.

@isidorn isidorn merged commit 7d6295f into microsoft:master Jan 23, 2018
@isidorn isidorn self-assigned this Jan 23, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 23, 2018
@usernamehw usernamehw deleted the revert_changes_running_extensions branch February 1, 2018 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@usernamehw @isidorn