Skip to content

Add workbench.fontAliasing.auto option #41895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2018
Merged

Add workbench.fontAliasing.auto option #41895

merged 3 commits into from
Jan 22, 2018

Conversation

Cryrivers
Copy link
Contributor

@Cryrivers Cryrivers commented Jan 20, 2018

Add workbench.fontAliasing.auto option, which applies default on non-retina displays and antialiased on retina displays automatically, adding some pleasure when moving vscode around multiple displays.

@msftclas
Copy link

msftclas commented Jan 20, 2018

CLA assistant check
All committers have signed the CLA.

@bpasero bpasero self-assigned this Jan 22, 2018
@bpasero bpasero added this to the On Deck milestone Jan 22, 2018
@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

@Cryrivers seems to work fine but I would make one change: instead of introducing a monaco-font-aliasing-default class name, simply not set any class by default on the body to get the default browser behaviour. It seems to me that e.g. on my macOS, the default is -webkit-font-smoothing: auto and not -webkit-font-smoothing: subpixel-antialiased

@Cryrivers
Copy link
Contributor Author

Cryrivers commented Jan 22, 2018

@bpasero thanks for the review. i'll make the change accordingly(i.e. removing monaco-font-aliasing-default). btw, i didn't find any information about what -webkit-font-smoothing: auto should behave. However, on my laptop (MacBook Pro 15" 2016) it behaves as same as subpixel-antialiased. If there's any exceptions, do let me know please.

@bpasero bpasero merged commit e7e7363 into microsoft:master Jan 22, 2018
@bpasero
Copy link
Member

bpasero commented Jan 22, 2018

@Cryrivers thanks!

@bpasero bpasero modified the milestones: On Deck, January 2018 Jan 22, 2018
@Cryrivers Cryrivers deleted the cryrivers/auto-font-hinting branch January 23, 2018 02:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants