Skip to content

Expose border style for debug toolbar. Fixes #39324 #39976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2017
Merged

Expose border style for debug toolbar. Fixes #39324 #39976

merged 2 commits into from
Dec 13, 2017

Conversation

usernamehw
Copy link
Contributor

@isidorn isidorn self-assigned this Dec 11, 2017
@isidorn isidorn added this to the December 2017 milestone Dec 11, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 12, 2017

@usernamehw great PR, thanks a lot!

Currently you add the border transparent even if the theme is not specifying the color, this means that the widget will be larger by 2px in the default case. Can we handle this same as with contrastBorderColor before, that is to not add the border at all if the theme does not contrbute this?

Once you adress this I will merge the PR in.

@isidorn
Copy link
Contributor

isidorn commented Dec 13, 2017

@usernamehw looks good to me, thanks a lot for the pr!
🍻

@isidorn isidorn merged commit 861bd52 into microsoft:master Dec 13, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@usernamehw @isidorn