Add line number interval setting

[djweber]

This adds a setting to control the interval at which line numbers are rendered in the editor, described in #36981. You can specify a numerical interval as well as whether or not to show the line number for the current cursor position.

[wiktor-k]

Looks very good! Thanks.

[alexdima]

For our users sake, who will have to figure out how to configure this setting, I would kindly ask that we remove the OR type for this setting... IMHO, it makes it too complicated.

[alexdima]

IMHO, the introduction of the OR type makes this setting too difficult to configure. It is technically correct, but does not align with the other editor settings.

I would remove the usage of the OR type.

[wiktor-k]

I've fixed issues reported by @alexandrudima (splitting settings) on top of @DDWR's changes but as I can't push these changes to this PR.

Should I create a new PR for that or would it be possible for maintainers to push my changes to this PR?

Thanks in advance for help!

[djweber]

@alexandrudima I thought it would be acceptable to use the union type since there are several throughout the configuration settings, with editor.quickSuggestions being a good example:

https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/config/commonEditorConfig.ts#L355

As requested, I made it so that lineNumberInterval is no longer a union type.

[alexdima]

The editor.quickSuggestions is a union type for backwards compatibility purposes and should not be used as a good example. It shipped for a couple of years as a boolean, and then someone in the team refined it.

[alexdima]

@DDWR Thank you for your contribution! ❤️

[elektronik2k5]

I would love to have a setting to control the line interval, as suggested here: #36981 (comment). The default 10 lines is too sparse, but using a configurable interval, I could set it to 5 or 2 to have just enough line numbers.

[djweber]

@elektronik2k5 The work I did on this PR did have a configurable interval length, but for whatever reason it was completely changed to being a hard-coded interval of 10. I had not noticed that my PR was heavily modified like this and am pretty surprised that no discussion was made around it. @alexandrudima can you please clarify why you made these changes?

[TrevorSayre]

@alexandrudima Is there any chance we can get back the ability to specify an interval?

[alexdima]

@dotweber @TrevorSayre

It perhaps does not make sense, but I'm actively trying to add as little as possible to VS Code. And when something is added, I'm trying as much as possible to make it simple to use / configure / discover.

The initial feature request at #36981 had 1 upvote, so AFAIK there were a grand total of 3 interested people in it. The feature request does not mention a configurable interval, so I assumed @dotweber is overdelivering. Plus the screenshots appear to use the value 10. Plus I honestly believe 10 is a good default, as the line numbers are presented in base 10.

I am open to bring the possibility to configure the line numbers interval. But let's start with a fresh feature request (i.e. please create one); PR also most welcome.

[F1LT3R]

I would also like to see the interval configurable.
And it would be good to have an option for current only, eg:

{
   "editor.lineNumbers": "current"
}