Skip to content

Fixed issue of Illegal git value for line #34781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2017
Merged

Fixed issue of Illegal git value for line #34781

merged 2 commits into from
Dec 11, 2017

Conversation

Jeyanthinath
Copy link
Contributor

fix vscode #32681

@ramya-rao-a ramya-rao-a requested a review from jrieken September 21, 2017 21:43
jrieken
jrieken requested changes Sep 22, 2017
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove/weaken the assertion but make sure that the calling side provides correct argument values.

@jrieken jrieken requested a review from joaomoreno September 25, 2017 06:52
@jrieken jrieken assigned joaomoreno and unassigned jrieken Sep 25, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Sep 25, 2017
@joaomoreno joaomoreno merged commit 282afd5 into microsoft:master Dec 11, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, December 2017 Dec 11, 2017
@joaomoreno joaomoreno added the git GIT issues label Dec 11, 2017
@joaomoreno joaomoreno mentioned this pull request Dec 11, 2017
Closed
@joaomoreno
Copy link
Member

Thanks! 🍻

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken requested changes

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joaomoreno joaomoreno

Labels
git GIT issues
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeyanthinath @joaomoreno @jrieken