Feature 29241: Add option to disable git indicators in gutter #29700
Conversation
|
@bugrac, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @alexandrudima to be potential reviewers. |
There was a problem hiding this comment.
If decorators are to be disabled, more needs to be done:
- You need to dispose and clean out all instances of
DirtyDiffModelDecorator. - You need to detach the
onEditorsChangedlistener.
You're also missing a configuration change listener, which should enable/disable the decorations accordingly.
| @@ -82,6 +83,20 @@ const viewletDescriptor = new ViewletDescriptor( | |||
| 36 | |||
| ); | |||
|
|
|||
| // Configuration | |||
| Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).registerConfiguration({ | |||
| id: 'editor', | |||
| order: 5, | ||
| type: 'object', | ||
| properties: { | ||
| 'editor.enableDecorators': { |
There was a problem hiding this comment.
The property should be scm.enableDiffDecorations.
| 'editor.enableDecorators': { | ||
| 'type': 'boolean', | ||
| 'default': true, | ||
| 'description': localize('enableDecorators', "Enables or disables color decorators when changes happen in the editor.") |
There was a problem hiding this comment.
Enables or disables diff decorations in modified files.
|
Thanks! 🍻 |
|
Went ahead and changed the setting to accommodate #21795 You can now control this with |
|
Thanks guys, great change. I've just switched to VS code and I'm curios why the modified colour for the gutter is blue whilst the modified colour on the file name itself is orange. To me it makes sense to make these the same colour by default |
Feature #29241: Add option to disable git indicators in gutter