Skip to content

editor - support toggled state for modal editor size#295199

Merged
bpasero merged 2 commits intomainfrom
ben/voluminous-mandrill
Feb 13, 2026
Merged

editor - support toggled state for modal editor size#295199
bpasero merged 2 commits intomainfrom
ben/voluminous-mandrill

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Feb 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 13, 2026 15:41
@bpasero bpasero enabled auto-merge (squash) February 13, 2026 15:41
@bpasero bpasero self-assigned this Feb 13, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the modal editor title toolbar to better reflect command toggled state (e.g., maximized vs. restored), aligning its behavior with other VS Code toolbars.

Changes:

  • Enable toggled-item highlighting in the modal editor title toolbar.
  • Adjust the modal editor maximize/restore action’s toggled configuration (removes the toggled icon).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/browser/parts/editor/modalEditorPart.ts Enables highlightToggledItems so checked/toggled actions can be visually indicated in the modal editor toolbar.
src/vs/workbench/browser/parts/editor/editorCommands.ts Updates the modal maximize action’s toggled presentation by removing the toggled icon override.

@bpasero bpasero merged commit bf09717 into main Feb 13, 2026
18 checks passed
@bpasero bpasero deleted the ben/voluminous-mandrill branch February 13, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants