fix declare const enum not inlined by esbuild, fixes #295046#295149
Merged
fix declare const enum not inlined by esbuild, fixes #295046#295149
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #295046 where declare const enum declarations were not being inlined by esbuild, causing ReferenceError at runtime. The esbuild bundler doesn't handle declare const enum correctly, leaving enum identifiers in the output instead of inlining the constant values. The solution removes the declare keyword from const enum declarations and adds an ESLint rule to prevent this issue in the future.
Changes:
- Removed
declarekeyword from two const enums (PromptNodeTypeandPieceCtorKind) in promptTsxTypes.ts - Added a new auto-fixable ESLint rule (
code-no-declare-const-enum) to prevent future occurrences - Registered the new ESLint rule in eslint.config.js
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/tools/promptTsxTypes.ts | Removed declare keyword from PromptNodeType and PieceCtorKind const enums and added explanatory comment about esbuild limitation |
| .eslint-plugin-local/code-no-declare-const-enum.ts | Added new ESLint rule to detect and auto-fix declare const enum declarations |
| eslint.config.js | Registered the new code-no-declare-const-enum rule in the ESLint configuration |
alexr00
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #295046