Skip to content

Store sessionResource as view state instead of id#294253

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/worldwide-rat
Feb 10, 2026
Merged

Store sessionResource as view state instead of id#294253
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/worldwide-rat

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Feb 10, 2026

For #274403

Should let us support non-local sessions too. Keeping around id support for backcompat

For microsoft#274403

Should let us support non-local sessions. Keeping around id support for backcompat
Copilot AI review requested due to automatic review settings February 10, 2026 23:19
@mjbvz mjbvz enabled auto-merge February 10, 2026 23:20
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the chat view pane to store the session resource as a URI in the view state instead of just a string ID. This is part of a larger effort (#274403) to migrate the chat implementation to use URIs instead of string IDs throughout, enabling better support for non-local contributed session providers.

Changes:

  • Added sessionResource?: URI field to IChatViewPaneState for storing session URIs
  • Marked existing sessionId field as deprecated while keeping it for backward compatibility
  • Updated session restoration logic to prefer sessionResource over sessionId with proper fallback

@mjbvz mjbvz merged commit b20cd36 into microsoft:main Feb 10, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants