Fix: Transform to Snake Case now handles kebab-case input - #288817
Open
Milad Rashidikhah (Milad93R) wants to merge 1 commit into
Open
Fix: Transform to Snake Case now handles kebab-case input#288817Milad Rashidikhah (Milad93R) wants to merge 1 commit into
Milad Rashidikhah (Milad93R) wants to merge 1 commit into
Conversation
Add hyphenBoundary regex pattern to SnakeCaseAction to convert hyphens to underscores, allowing kebab-case text like 'hello-this-is-kebab-case' to properly transform to 'hello_this_is_kebab_case'. Fixes microsoft#288603
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyphenBoundaryregex pattern toSnakeCaseActionto handle kebab-case inputhello-this-is-kebab-casenow correctly transforms tohello_this_is_kebab_caseChanges
src/vs/editor/contrib/linesOperations/browser/linesOperations.ts: Added hyphen boundary detection using the same pattern asKebabCaseActionuses for underscoressrc/vs/editor/contrib/linesOperations/test/browser/linesOperations.test.ts: Added test case for kebab-case to snake_case conversionTest plan
hello-this-is-kebab-case→hello_this_is_kebab_casekebab-case-WITH-Mixed→kebab_case_with_mixedaudio-converter.convert-M4A-to-MP3→audio_converter.convert_m4a_to_mp3Fixes #288603