Conversation
Additional sandbox negotiation options Refs modelcontextprotocol/ext-apps#158
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adopts changes from modelcontextprotocol/ext-apps#158 to add sandbox negotiation capabilities to the MCP (Model Context Protocol) Apps interface. The changes enable more fine-grained control over Content Security Policy and permissions for MCP app webviews.
Changes:
- Adds new CSP domain types (frameDomains, baseUriDomains) and permissions interface (camera, microphone, geolocation, clipboardWrite)
- Introduces sandbox capability negotiation where hosts can announce supported permissions and CSP policies to guest apps during initialization
- Makes toolInfo.id and resourceUri optional fields to support more flexible protocol usage
- Adds method string constants for type-safe message method checking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/common/modelContextProtocolApps.ts | Updates MCP Apps protocol schema with new sandbox negotiation types, permissions interface, method constants, and makes certain fields optional |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatMcpAppModel.ts | Implements sandbox negotiation by storing CSP configuration, using new CSP directives for frame-src and base-uri, and announcing sandbox capabilities during initialization |
alexr00
approved these changes
Jan 12, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
Additional sandbox negotiation options Refs modelcontextprotocol/ext-apps#158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional sandbox negotiation options
Refs modelcontextprotocol/ext-apps#158