Filter unsupported items from 'Add Context' quick pick #270660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where unsupported views (webviews, settings panes, welcome pages) could be added to chat context through the quick pick, resulting in errors. The solution filters out items with specific URI schemes that are not supported for chat context.
- Adds a constant set of unsupported context schemes
- Implements a filter function in the quick pick options to exclude unsupported schemes
eleanorjboyd
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255443
Context
If you add an unsupported view (webview, settings pane, welcome page) to the context via quick pick, it gets included in context but shows up as an error.
Changes Made
Added a filter to the quick pick that excludes views with specific schemes.