Skip to content

Fix: Allow SVG files as chat attachments (as code/text, not images) #270608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+8 −3
Closed

Fix: Allow SVG files as chat attachments (as code/text, not images) #270608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8196e8e
Initial plan
Copilot Oct 9, 2025
75af08d
Add SVG support to CHAT_ATTACHABLE_IMAGE_MIME_TYPES and add tests
Copilot Oct 9, 2025
2f8d814
Treat SVG files as code/text instead of images in chat attachments
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/vs/workbench/contrib/chat/browser/chatDragAndDrop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,11 @@ export class ChatDragAndDrop extends Themable {
}
}

function isImageMimeType(mimeType: string): boolean {
// SVG files should be treated as code/text, not images
return mimeType.startsWith('image/') && !mimeType.startsWith('image/svg');
}

function containsImageDragType(e: DragEvent): boolean {
// Image detection should not have false positives, only false negatives are allowed
if (containsDragType(e, 'image')) {
Expand All @@ -420,12 +425,12 @@ function containsImageDragType(e: DragEvent): boolean {
if (containsDragType(e, DataTransfers.FILES)) {
const files = e.dataTransfer?.files;
if (files && files.length > 0) {
return Array.from(files).some(file => file.type.startsWith('image/'));
return Array.from(files).some(file => isImageMimeType(file.type));
}

const items = e.dataTransfer?.items;
if (items && items.length > 0) {
return Array.from(items).some(item => item.type.startsWith('image/'));
return Array.from(items).some(item => isImageMimeType(item.type));
}
}

Expand Down Expand Up @@ -455,5 +460,5 @@ function extractImageFilesFromDragEvent(e: DragEvent): File[] {
return [];
}

return Array.from(files).filter(file => file.type.startsWith('image/'));
return Array.from(files).filter(file => isImageMimeType(file.type));
}