mcp: implement close transport message for streamable http #270433
+40
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements proper close transport message handling for streamable HTTP connections in the MCP (Model Context Protocol) service. The changes ensure that HTTP sessions are properly terminated when connections are stopped.
- Adds session cleanup logic with proper HTTP DELETE requests for active sessions
- Implements graceful connection state management with close tracking
- Refactors the stop logic to handle both immediate and deferred cleanup scenarios
| this._launch.uri.toString(true), | ||
| { | ||
| method: 'DELETE', | ||
| headers: { 'Mcp-Session-Id': sessionId }, |
There was a problem hiding this comment.
The headers object is constructed with session ID on line 274, then auth headers are added on line 277, but the fetch call on line 284 only uses a new headers object with just the session ID, ignoring the auth headers that were added.
Suggested change
| headers: { 'Mcp-Session-Id': sessionId }, | |
| headers, |
Copilot uses AI. Check for mistakes.
hediet
previously approved these changes
Oct 8, 2025
connor4312
force-pushed
the
connor4312/issue263068
branch
from
6c83729 to
aefc123
Compare
dmitrivMS
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263068