Fix swapped findMatch foreground colors (#228782) #270395
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the editor.findMatchForeground and editor.findMatchHighlightForeground color settings were incorrectly swapped in the find widget implementation. The fix ensures that the documented color semantics are properly applied to their intended elements.
- Corrected assignment of
editor.findMatchForegroundto target the current search match - Corrected assignment of
editor.findMatchHighlightForegroundto target other search matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
editor.findMatchForegroundandeditor.findMatchHighlightForegroundcolor settings were swapped.Problem
The find match foreground colors were incorrectly assigned:
editor.findMatchForeground(documented as “current search match”) was applied to other matches.editor.findMatchHighlightForeground(documented as “other search matches”) was applied to the current match.Solution
Swapped the CSS class selectors in
findWidget.ts:editor.findMatchForegroundnow correctly targets.currentFindMatchInline(current match)editor.findMatchHighlightForegroundnow correctly targets.findMatchInline(other matches)Before
After
Test Plan
editor.findMatchForegroundto a distinct color and verify it colors the current match.editor.findMatchHighlightForegroundto a distinct color and verify it colors other matches.