Remove deprecated managedhover from findwidget + toggle #270313
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
@joaomorenoMatched files:
@benibenjMatched files:
|
This doesn't work without adoption in IBaseActionViewItemOptions
| /** @deprecated Prefer hoverStyle and hoverLifecycleOptions instead */ | ||
| readonly hoverDelegate?: IHoverDelegate; | ||
| readonly hoverStyle?: HoverStyle; | ||
| readonly hoverLifecycleOptions?: IHoverLifecycleOptions; |
There was a problem hiding this comment.
@benibenj what do you think about this as a way to get rid of hoverDelegate in base? I think base only needs to set a groupId and a style (pointer or mouse). We don't want to be passing around callbacks to setupDelayedHover or setupDelayedHoverAtMouse inside options so simple options like this are preferable.
There was a problem hiding this comment.
I build upon this in #270749 attempting to do the same for IBaseActionViewItemOptions but I might abandon it there as it's a lot of work to validate and a huge change that can't really be done in stages AFAICT and I wanted to get your view on the HoverStyle and lifecycle options replacing hoverDelegate.
Part of #243348
Part of #270314