re-enable tests to look for failure #270299
Merged
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
force-pushed
the
aamunger/smokin
branch
from
2cf9c9d to
e06b9ac
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables previously skipped smoke tests for notebook functionality to monitor if they are still flakey. The main purpose is to observe test behavior and identify potential issues.
Key changes:
- Re-enabled four notebook smoke tests by changing
it.skip()toit() - Updated test automation infrastructure to better handle notebook UI elements
- Added new context key for broader notebook editor detection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/smoke/src/areas/notebook/notebook.test.ts | Re-enabled tests and updated assertions to handle current notebook behavior |
| test/automation/src/notebook.ts | Enhanced selectors and improved notebook automation reliability |
| src/vs/workbench/contrib/notebook/common/notebookContextKeys.ts | Added combined context key for all notebook editor types |
| src/vs/workbench/contrib/notebook/browser/contrib/navigation/arrow.ts | Updated command registration with better context conditions |
rebornix
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't gotten these to fail yet, so re-enabling to see if they are still flakey.