Repository navigation
Chat - switch chat toolbar to use overlay widget - #268005
Draft
Ladislau Szomoru (lszomoru) wants to merge 5 commits into
Draft
Ladislau Szomoru (lszomoru) wants to merge 5 commits into
Ladislau Szomoru (lszomoru) wants to merge 5 commits into
Conversation
Ladislau Szomoru (lszomoru)
requested a review
from Johannes Rieken (jrieken)
September 23, 2025 16:31
Ladislau Szomoru (lszomoru)
enabled auto-merge (squash)
September 23, 2025 16:31
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the chat editing toolbar from absolute positioning within a container to using VS Code's overlay widget system. This provides better integration with the editor's layout and z-index management.
Key changes:
- Migrates chat toolbar from DOM container positioning to editor overlay widget
- Implements widget stacking system with ordinal values for proper layering
- Updates overlay widget positioning logic to support stacking for both top and bottom right corners
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts |
Converts chat toolbar from absolute positioning to overlay widget with stack ordinal 1 |
src/vs/editor/contrib/floatingMenu/browser/floatingMenu.ts |
Adds stack ordinal 2 to floating menu to ensure proper layering above chat toolbar |
src/vs/editor/browser/viewParts/overlayWidgets/overlayWidgets.ts |
Implements widget stacking logic for both top and bottom right corner positions |
Contributor
|
I like the stacking but the reason for this not being an overlay widget (anymore) is that it should also work for notebooks. So, we would need to find a solution for that first |
Member
Author
|
Johannes Rieken (@jrieken), that makes sense. I did not consider the notebook scenario. |
Ladislau Szomoru (lszomoru)
marked this pull request as draft
October 28, 2025 19:18
auto-merge was automatically disabled
October 28, 2025 19:18
Pull request was converted to draft
Member
Author
|
Converting to draft to make sure that this does not get merged in its current form. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request switches the chat session toolbar to use an overlay widget so that we can take advantage of stacking overlay widgets in the lower right hand corner in order to address the edge case in which both the chat session toolbar is being shown as well as the "editor content button" (ex: Resolve in Merge Editor). PR also contains a drive-by fix for stacking overlay widgets in the top/bottom right corners.