Skip to content

Chat - switch chat toolbar to use overlay widget - #268005

Draft
Ladislau Szomoru (lszomoru) wants to merge 5 commits into
mainfrom
lszomoru/chat-overlay-toolbar
Draft

Ladislau Szomoru (lszomoru) wants to merge 5 commits into
mainfrom
lszomoru/chat-overlay-toolbar

Conversation

@lszomoru

@lszomoru Ladislau Szomoru (lszomoru) commented Sep 23, 2025 •

Copy link
Copy Markdown
Member

This pull request switches the chat session toolbar to use an overlay widget so that we can take advantage of stacking overlay widgets in the lower right hand corner in order to address the edge case in which both the chat session toolbar is being shown as well as the "editor content button" (ex: Resolve in Merge Editor). PR also contains a drive-by fix for stacking overlay widgets in the top/bottom right corners.

image

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the chat editing toolbar from absolute positioning within a container to using VS Code's overlay widget system. This provides better integration with the editor's layout and z-index management.

Key changes:

  • Migrates chat toolbar from DOM container positioning to editor overlay widget
  • Implements widget stacking system with ordinal values for proper layering
  • Updates overlay widget positioning logic to support stacking for both top and bottom right corners

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts Converts chat toolbar from absolute positioning to overlay widget with stack ordinal 1
src/vs/editor/contrib/floatingMenu/browser/floatingMenu.ts Adds stack ordinal 2 to floating menu to ensure proper layering above chat toolbar
src/vs/editor/browser/viewParts/overlayWidgets/overlayWidgets.ts Implements widget stacking logic for both top and bottom right corner positions

Comment thread src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingEditorOverlay.ts Outdated
Comment thread src/vs/editor/browser/viewParts/overlayWidgets/overlayWidgets.ts
@jrieken

Copy link
Copy Markdown
Contributor

I like the stacking but the reason for this not being an overlay widget (anymore) is that it should also work for notebooks. So, we would need to find a solution for that first

@lszomoru

Copy link
Copy Markdown
Member Author

Johannes Rieken (@jrieken), that makes sense. I did not consider the notebook scenario.

@lszomoru
Ladislau Szomoru (lszomoru) marked this pull request as draft October 28, 2025 19:18
auto-merge was automatically disabled October 28, 2025 19:18

Pull request was converted to draft

@lszomoru

Copy link
Copy Markdown
Member Author

Converting to draft to make sure that this does not get merged in its current form.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants