Merged
Conversation
mjbvz
reviewed
Aug 27, 2025
| /** | ||
| * Options for the session | ||
| */ | ||
| readonly options?: { |
Collaborator
There was a problem hiding this comment.
Maybe capabilities? And should this be on the provider instead if it's going to be the same for all sessions from it? Something like:
registerChatSessionContentProvider(type, provider, capabilities?: { supportsHotReload? boolean })
Member
Author
There was a problem hiding this comment.
Nice, I like capabilities.
| * Useful when the chat session can handle interruptions gracefully, e.g. when the chat session pulls | ||
| * from a remote provider and can be reattached to. | ||
| */ | ||
| readonly supportsHotReload?: boolean; |
Collaborator
There was a problem hiding this comment.
hot reload as a name doesn't feel quite right to me. Maybe something like supportsInterruptions?
Member
Author
|
@copilot make the PR suggestions |
mjbvz
approved these changes
Aug 27, 2025
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Thanks for making the changes. API look is looking good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #259967