-
Notifications
You must be signed in to change notification settings - Fork 35.5k
Add RTL support based on decorations #255455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds RTL support to Monaco editor. A line can be marked as RTL using decorations. Decorations can now specify a text direction. For every line, the decorations on that line are counted which specify the text direction. If there are more RTL decorations than there are RTL decorations, the line is considered RTL. If a line is RTL, the content is aligned to the right side of the screen, taking the scrollbar into account. If text content matches the text direction, pressing a left or right arrow key, moves the cursor into the same direction. If the content is of the inverse direction, the cursor is moved into the opposite direction. The `Home` key moves the cursor to the start of the line. In case of RTL, this is the right. The `End` key moves the cursor to the end of the line. In case of RTL, this is the left. These cursor movements also work for multi selections. Both RTL and LTR work with or without text wrapping, even with the advanced text wrapping strategy.
remcohaszing
commented
Jul 11, 2025
I forgot to mention a couple of details.
I see you’re making some changes to my PR. Let me know if you need more info or I can help otherwise. |
alexdima
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
DonJayamanne
approved these changes
Jul 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds RTL support to Monaco editor. A line can be marked as RTL using decorations. Decorations can now specify a text direction. For every line, the decorations on that line are counted which specify the text direction. If there are more RTL decorations than there are RTL decorations, the line is considered RTL.
If a line is RTL, the content is aligned to the right side of the screen, taking the scrollbar into account.
If text content matches the text direction, pressing a left or right arrow key, moves the cursor into the same direction. If the content is of the inverse direction, the cursor is moved into the opposite direction.
The Home key moves the cursor to the start of the line. In case of RTL, this is the right.
The End key moves the cursor to the end of the line. In case of RTL, this is the left.
These cursor movements also work for multi selections.
Both RTL and LTR work with or without text wrapping, even with the advanced text wrapping strategy.