Skip to content

Fix summarization progress message breaking list rendering #249151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

roblourens
Copy link
Member

Fix #249148

@roblourens roblourens self-assigned this May 16, 2025
@roblourens roblourens enabled auto-merge (squash) May 16, 2025 23:14
@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 16, 2025
@roblourens
Copy link
Member Author

roblourens commented May 16, 2025

@jrieken from #249105. Thanks for cleaning up this code assigning handles for the progress task. Real culprit is this line: : revive(progress) as IChatProgress; which is a bit weird because IChatProgressDto is not actually compatible with IChatProgress. Not sure what the proper fix is, progress task is an oddball.

We've had many issues with serializing/deserializing all these different types in different scenarios and really I need to find the right pattern for this and eliminate any special cases.

@roblourens roblourens merged commit e789421 into main May 16, 2025
8 checks passed
@roblourens roblourens deleted the roblou/major-gerbil branch May 16, 2025 23:26
@jrieken
Copy link
Member

jrieken commented May 19, 2025

@roblourens Thanks for the fix and sorry for the breakage. I remember thinking really hard about the code and still came to the wrong conclusion :-)

Yeah, the handles are now assigned on the EH side so that chat progress can be send in bulks. That was needed for the new/better editing UX

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jun 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"summarizing" task breaks chat view
3 participants