Initial basic GPU renderer for editor #225413
Merged
+3,642
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esetono1994
approved these changes
Sep 4, 2024
| "mocha", | ||
| "semver", | ||
| "sinon", | ||
| "winreg", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Tyriar
changed the title
|
@hediet this is passing now and ready to merge. |
hediet
reviewed
Sep 10, 2024
hediet
previously requested changes
Sep 10, 2024
There was a problem hiding this comment.
The only real thing I found is that previously the viewLines object was not pushed to the view part array, whereas now it is - which might cause bugs.
I only skimmed through the added files, but didn't get a deep understanding of the implementation. Also couldn't find anything obvious.
Good work! I'm curious to selfhost on this!
This will help us find out if/when this actually happens in practice.
joyceerhl
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #221145
Part of #221210