-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer action to show gpu status #222291
base: main
Are you sure you want to change the base?
Conversation
Thanks for working on this, the current result from |
Oh, that makes sense. I will work on this. |
7dd4ce9
to
6559290
Compare
@deepak1556 I got some updates in this PR. |
The feature is only needed in desktop, for web users can get the info from respective browsers using the standard way. |
6559290
to
8b275f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, just a few comments
Sorry for the late review here but I wonder if the added files and services is a bit overkill for what we want to achieve here? I think a service is good if there are multiple users but I think here what we want is to open a window with the GPU info. We could simply do that from the |
9af07d1
to
574ab9d
Compare
Sorry I missed the ping on this. Changes LGTM but we have currently closed the |
Closes #92586
Provide a way to show gpu status