code actions on save for autosave afterDelay
#221785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jul 18, 2024
src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/codeEditor/browser/saveParticipants.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private async triggerCodeActionsCommand() { | ||
| if (this.configurationService.getValue<boolean>('editor.codeActions.triggerOnFocusChange') && this.configurationService.getValue<string>('files.autoSave') === 'afterDelay') { |
There was a problem hiding this comment.
Are there any constants we can use for these setting IDs instead?
Comment on lines
+52
to
+54
| 'editor.codeActions.triggerOnFocusChange': { | ||
| type: 'boolean', | ||
| scope: ConfigurationScope.LANGUAGE_OVERRIDABLE, |
There was a problem hiding this comment.
"value of this configuration will be read only from trusted sources." not entirely sure what this means? our other code actions on save aren't restricted iirc, but unsure if this needs or not
src/vs/editor/contrib/codeAction/browser/codeActionContributions.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Jul 19, 2024
|
Thanks for the updates 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #200881
This will trigger code actions for organize imports when the following conditions are applied:
afterDelaysource.organizeImports) is set toalwayseditor.codeActions.triggerOnFocusChangeistrue(default is false)note: will still be triggered when
afterDelayis on and we manually trigger a safe (same as current behavior)TLDR: we match the behavior of
onFocusChangeoronWindowChangesave styles when code actions arealwaysand our save style isafterDelay