Make sure any status bar item created by extension has meaningful id #214959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an extension does not specify the id of the status bar item, it still makes sense to generate the identifier that includes extension id. Otherwise, in case of multiple extension hosts, it is possibile that during the initialization, different extension hosts may generate the same sequential id and one of the status bar items will not be visible.
BaljeettheBro
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an extension does not specify the id of the status bar item, it still makes sense to generate the identifier that includes extension id. Otherwise, in case of multiple extension hosts, it is possibile that during the initialization, different extension hosts may generate the same sequential id and one of the status bar items will not be visible.