Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Implement Dynamic Positioning of Icon Picker Based on Event Source #211649

Closed

Conversation

sossost
Copy link

@sossost sossost commented Apr 29, 2024

Fixed #211083
By integrating the eventSource parameter into the changeIcon method, the icon picker now appears at appropriate locations relative to the trigger point—either below the command center when triggered via the command palette or near the terminal tab when triggered from there.

-when tirggered in terminal tab
스크린샷 2024-05-03 오후 10 33 35

-when triggered in commend center
스크린샷 2024-05-03 오후 10 37 54

@sossost sossost changed the title Fix terminal icon picker placement Fix : Implement Dynamic Positioning of Icon Picker Based on Event Source Apr 29, 2024
@sossost
Copy link
Author

sossost commented Apr 30, 2024

@microsoft-github-policy-service agree

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to be a bit broken currently:

image

I'll close this in favor of #212174 which is quite close to being the right fix. Thanks for the PR!

@Tyriar Tyriar closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal Icon picker weird placement
2 participants