Fix platform detection after Node.js 21 #200935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js 21 added `navigator.userAgent`, which breaks the previous detection.
Contributor
Author
|
The same problem happen in |
kkocdko
commented
Dec 15, 2023
| _language = _locale; | ||
| _platformLocale = navigator.language; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Only reorder two code block, without change the block content.
| declare const navigator: INavigator; | ||
|
|
||
| // Web environment | ||
| if (typeof navigator === 'object' && !isElectronRenderer) { |
Contributor
Author
There was a problem hiding this comment.
Previous detection expect that Node.js doesn't have navigator, now Node.js 21 had, with navigator.userAgent === 'Node.js/21' .
deepak1556
approved these changes
Dec 15, 2023
Collaborator
There was a problem hiding this comment.
LGTM, thanks!
/cc @bpasero for another set of 👀
bpasero
approved these changes
Dec 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 21 added
navigator.userAgent, which breaks the previous detection.Close #200934