Prevent duplicate text in workspace folder picker when path has no parent (fix #183418) #183427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
requested review from
bpasero
and removed request for
Tyriar and
meganrogge
bpasero
requested changes
May 25, 2023
There was a problem hiding this comment.
This change seems strange to me. I think the intent here is to not show description when the result matches that of label. I would prefer a solution that computes label and description and then compares both and ignoring description when they are the same. Anything else is strange path magic that we should stay away from imho.
|
Pushed a change which gives this for the testcase:
|
bpasero
requested changes
May 25, 2023
bpasero
approved these changes
May 26, 2023
sandy081
approved these changes
May 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #183418, which contains repro steps suitable for testing.