Fix cannot hide terminal find widget when pressing esc
#183090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
May 22, 2023
src/vs/workbench/contrib/terminalContrib/find/browser/terminal.find.contribution.ts
Outdated
Show resolved
Hide resolved
Tyriar
requested changes
May 22, 2023
Tyriar
approved these changes
May 23, 2023
andreamah
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183087
Before, find contribution was using the global contextService so context keys values were incorrect, convert to a proper terminal contribution so the terminal instance scoped contextService is used instead.
cc @Tyriar