Skip to content

Fix Improve terminal find behavior when there are more than 1000 results #182917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2023
Merged

Fix Improve terminal find behavior when there are more than 1000 results #182917

merged 3 commits into from
May 19, 2023

Conversation

jeanp413
Copy link
Contributor

Fixes #178017

@jeanp413 jeanp413 mentioned this pull request May 18, 2023
Closed
@Tyriar
Copy link
Member

Tyriar commented May 19, 2023

@jeanp413 FYI external contributors cannot update any dependencies for security reasons (too hard to review yarn.lock changes). I created #182963, you might need to revert the changes in this PR when that's merged. Pinging us in the PR for what to update is probably the easiest way.

@Tyriar Tyriar added this to the May 2023 milestone May 19, 2023
@Tyriar Tyriar self-requested a review May 19, 2023 16:09
Tyriar
Tyriar approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @jeanp413 🎉

@Tyriar Tyriar enabled auto-merge May 19, 2023 17:30
@Tyriar Tyriar merged commit 655f127 into microsoft:main May 19, 2023
@jeanp413 jeanp413 deleted the fix-178017 branch May 19, 2023 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@connor4312 connor4312 connor4312 approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

Improve terminal find behavior when there are more than 1000 results
3 participants
@jeanp413 @Tyriar @connor4312