Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back hack to refresh terminal scroll bar #181359

Merged
merged 2 commits into from
May 3, 2023
Merged

Bring back hack to refresh terminal scroll bar #181359

merged 2 commits into from
May 3, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 2, 2023

Regressed in #164408
Fixes #174380

@Tyriar Tyriar added this to the May 2023 milestone May 2, 2023
@Tyriar Tyriar requested a review from meganrogge May 2, 2023 21:53
@Tyriar Tyriar self-assigned this May 2, 2023
@Tyriar Tyriar mentioned this pull request May 2, 2023
Open
@jeanp413
Copy link
Contributor

jeanp413 commented May 2, 2023

Sorry about it 🙏 , but from the code seems this will only work for one terminal what if I have a split terminal

meganrogge
meganrogge previously approved these changes May 2, 2023
View reviewed changes
@jeanp413
Copy link
Contributor

jeanp413 commented May 2, 2023 •
edited
Loading

Actually the fix is to add a timeout to forceRefresh call in TerminalInstance.setVisible, setVisible is already called correctly when toggling the panel: setTimeout(() => this.xterm?.forceRefresh(), 0);

@Tyriar
Move workaround into TerminalInstance.setVisible
c4e0149 
This works for all terminals, including split panes when async
@Tyriar Tyriar enabled auto-merge May 3, 2023 14:39
@Tyriar Tyriar requested a review from meganrogge May 3, 2023 14:39
meganrogge
meganrogge approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but LGTM

@Tyriar Tyriar merged commit cb672ba into main May 3, 2023
@Tyriar Tyriar deleted the tyriar/174380 branch May 3, 2023 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

"Toggle panel visibility" binding causes scroll up in integrated terminal
3 participants
@Tyriar @jeanp413 @meganrogge