-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pty host starter interface and move pty host to main process #178708
Conversation
Where I ended up getting on this:
|
// HACK: When RemoteLoggerChannelClient is not delayed, the Pty Host log file won't show up | ||
// in the Output view of the first window? | ||
Event.once(Event.any(proxy.onProcessReady, proxy.onProcessReplay))(() => { | ||
this._register(new RemoteLoggerChannelClient(this._loggerService, client.getChannel(TerminalIpcChannels.Logger))); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why but logging will not work without delaying it like this, it seems to register the logger when called regardless, it just doesn't show up in the first window's output view 😕
Finally past logging, looking into why remote terminals aren't working now |
Web remote terminals work, but the desktop pty host process exits almost immediately |
It's conpty again, terminals work everywhere when it's disabled, but it somehow takes down the remote pty host in the desktop case only now (not web/server) |
Struggling to see much of a difference, especially on remote as the process didn't move there |
The test resolver (doesn't work) and the web target (does work), both seemt o use the same version of node ( |
Still stuck on this conpty thing, I'm doing a product build to see if the issue is there too, if not I'm going to move ahead with this. |
It seems to work, if there is an issue it would be restricted to remote Windows which I'm not sure how to set up locally. |
// console.log('use utility proc'); | ||
|
||
// // TODO: Convert to use utility process | ||
// const opts: IIPCOptions = { | ||
// serverName: 'Pty Host', | ||
// args: ['--type=ptyHost', '--logsPath', this._environmentService.logsHome.fsPath], | ||
// env: { | ||
// VSCODE_LAST_PTY_ID: lastPtyId, | ||
// VSCODE_PTY_REMOTE: this._isRemote, | ||
// VSCODE_AMD_ENTRYPOINT: 'vs/platform/terminal/node/ptyHostMain', | ||
// VSCODE_PIPE_LOGGING: 'true', | ||
// VSCODE_VERBOSE_LOGGING: 'true', // transmit console logs from server to client, | ||
// VSCODE_RECONNECT_GRACE_TIME: this._reconnectConstants.graceTime, | ||
// VSCODE_RECONNECT_SHORT_GRACE_TIME: this._reconnectConstants.shortGraceTime, | ||
// VSCODE_RECONNECT_SCROLLBACK: this._reconnectConstants.scrollback | ||
// } | ||
// }; | ||
|
||
// const ptyHostDebug = parsePtyHostDebugPort(this._environmentService.args, this._environmentService.isBuilt); | ||
// if (ptyHostDebug) { | ||
// if (ptyHostDebug.break && ptyHostDebug.port) { | ||
// opts.debugBrk = ptyHostDebug.port; | ||
// } else if (!ptyHostDebug.break && ptyHostDebug.port) { | ||
// opts.debug = ptyHostDebug.port; | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out code
Part of #175335