fix: adding escape command in order to focus out of the sticky scroll #178020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the focus to the editor from the sticky scroll
aiday-mar
added
editor-sticky-scroll
bug
aiday-mar
changed the title
Tyriar
requested changes
Mar 22, 2023
src/vs/editor/contrib/stickyScroll/browser/stickyScrollActions.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/stickyScroll/browser/stickyScrollActions.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Mar 22, 2023
|
|
||
| constructor() { | ||
| super({ | ||
| id: 'editor.action.selectEditor', |
There was a problem hiding this comment.
I'm not the best person to ask but not sure the ideal name for this, should a contrib be registering unprefixed editor.action.* commands?
There was a problem hiding this comment.
I'll talk with the team about it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177871
Simple fix to add escape command to focus out of the sticky scroll