Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show infinite notebook progress if webview fails to init #176680

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Mar 9, 2023

For #166860

Adds a fatalError event that notebooks can use to know when their webview will never load

For microsoft#166860

Adds a `fatalError` event that notebooks can use to know when their webview will never load
@mjbvz mjbvz added this to the March 2023 milestone Mar 9, 2023
@mjbvz mjbvz requested a review from rebornix March 9, 2023 19:35
@mjbvz mjbvz self-assigned this Mar 9, 2023
@mjbvz mjbvz enabled auto-merge (squash) March 9, 2023 19:35
@mjbvz mjbvz changed the title Don't show infinite notebook progress is webview fails to init Don't show infinite notebook progress if webview fails to init Mar 9, 2023
@mjbvz mjbvz merged commit 2486976 into microsoft:main Mar 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants