Search perf improvements #176098

andreamah · 2023-03-03T23:51:26Z

Addresses #171436

Includes these improvements:

schedules tree refreshes instead of only using setInterval with a set amount of time to reduce over-calling refreshTree
optimize how we keep nodes collapsed/expanded using new collapses states from Tree: Allow preserving preexisting element collapse state #176505

src/vs/workbench/contrib/search/browser/searchView.ts

Don't refresh tree if still updating count

f3bd0ab

andreamah self-assigned this Mar 3, 2023

andreamah added 2 commits March 3, 2023 15:57

add try finally

4be87af

add scheduler to updateCount

aa72d47

andreamah dismissed a stale review via aa72d47 March 7, 2023 19:38

andreamah added 2 commits March 8, 2023 10:13

Merge branch 'main' into andreamah/issue171436

3c54b7c

edit node state preservation on search

a3753b0

andreamah changed the title ~~Don't refresh tree if still updating count~~ Search perf improvements Mar 8, 2023

fix update count code to properly schedule

fd7f45a

andreamah requested a review from roblourens March 8, 2023 19:07

andreamah marked this pull request as ready for review March 8, 2023 19:07

vscodenpa added this to the March 2023 milestone Mar 8, 2023

add try finally

f9ec240

roblourens reviewed Mar 9, 2023

View reviewed changes

src/vs/workbench/contrib/search/browser/searchView.ts Outdated Show resolved Hide resolved

move track updateUI scheduler in object

0f0a45f

roblourens previously approved these changes Mar 10, 2023

View reviewed changes

src/vs/workbench/contrib/search/browser/searchView.ts Outdated Show resolved Hide resolved

use this._register

fb89a70

andreamah dismissed roblourens’s stale review via fb89a70 March 10, 2023 00:14

rzhao271 reviewed Mar 10, 2023

View reviewed changes

src/vs/workbench/contrib/search/browser/searchView.ts Outdated Show resolved Hide resolved

remove _uiRefreshHandle

6b8d9c7

rzhao271 approved these changes Mar 10, 2023

View reviewed changes

andreamah enabled auto-merge (squash) March 10, 2023 00:49

andreamah merged commit fc12c7e into main Mar 10, 2023

andreamah deleted the andreamah/issue171436 branch March 10, 2023 01:02

github-actions bot locked and limited conversation to collaborators Apr 24, 2023

Provide feedback