Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain empty variables when creating term env #175682

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Retain empty variables when creating term env #175682

merged 1 commit into from
Feb 28, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 28, 2023

Fixes #174330

@Tyriar Tyriar added this to the March 2023 milestone Feb 28, 2023
@Tyriar Tyriar self-assigned this Feb 28, 2023
meganrogge
meganrogge approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear why one would set an env variable to empty, but lgtm

@Tyriar
Copy link
Member Author

Tyriar commented Feb 28, 2023 •
edited
Loading

Verified this works on mac, Windows doesn't seem to allow empty env vars.

@Tyriar Tyriar merged commit 69108b1 into main Feb 28, 2023
@Tyriar Tyriar deleted the tyriar/174330 branch February 28, 2023 19:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

Empty environment variables passed to vs code are unset
2 participants
@Tyriar @meganrogge