Crossfile typescript suport #171195
Closed
mjbvz wants to merge 63 commits into
Closed
Conversation
Because I dont have the default browser set up correctnly on any of my machiens
And some logging as I figure out how to use it
Use webpack's CopyPlugin transform pattern to do this manually. This is probably a bad idea! It's just for prototyping purposes.
Nonetheless required for it to work!
Another typo. Guess my local test wasn't running the contents really
Also: - tsserver.js is no longer minified - log crossOriginIsolated
Because it's browser-specific
Build only the ts parts of tsserver.web.js, don't rebuild the vscode extension. This is a lot faster.
Sheetal showed me the correct way to create a verbose logger instead.
And make isWeb support semantic mode.
Also paste in some example code for cancellation, which is not finished at all.
Watching the entire filesystem recursively is supposed to be inefficient. Not done yet: there is an error when watching directories, but it works. And I can't tell whether watching files works yet.
Now the syntax server actually runs as a syntax server.
1. Remove a little logging. 2. Correct failure return value for getFileSize 3. Reorder some methods and parameters.
I'm not sure if it's OK to depend on a module from another extension; it's probably better to include the files from a central place instead.
1. Copy and adapt implementations from node host where possible. 2. Note questions for the PR elsewhere. 3. Remove logging except for caught exceptions.
Also gate it behind a check to `crossOriginIsolated`
It won't minimise it *much*, but I also consolidated some unnecessarily-spread-out code that will be easier to read in the long term, and possibly easier to read in diff form as well.
Copy from markdown extension to typescript extension. I used the existing dependencies in the typescript extension, but verified that they would work the same.
…y prefix when project wide intellisense is disabled
Symlinks are implicitly supported by the filesystem right now.
meganrogge
approved these changes
Jan 12, 2023
meganrogge
approved these changes
Jan 12, 2023
mjbvz
enabled auto-merge (squash)
January 12, 2023 19:06
Contributor
Author
|
Actually may be able to submit #169311 with new checks. Closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simply a resubmission of #169311 from my account so that we can make the yarn.lock change