Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't focus the first element when a screen reader is in use #169169

Closed
wants to merge 4 commits into from
Closed

don't focus the first element when a screen reader is in use #169169

wants to merge 4 commits into from

Conversation

meganrogge
Copy link
Contributor

fix #166920

@meganrogge meganrogge self-assigned this Dec 14, 2022
@meganrogge meganrogge added this to the January 2023 milestone Dec 14, 2022
TylerLeonhardt
TylerLeonhardt requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right fix. I think we should keep this function as is, and then see if the usages of this function should behave differently if we are using a screenreader

@meganrogge
Copy link
Contributor Author

It appears this fix is not working. I'm not sure where else the item gets selected/focused

@meganrogge meganrogge closed this Dec 14, 2022
@meganrogge meganrogge reopened this Jan 17, 2023
@meganrogge
Copy link
Contributor Author

we've decided this isn't the right approach

@meganrogge meganrogge closed this Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
@meganrogge meganrogge deleted the merogge/screenReader branch October 26, 2023 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

NVDA/JAWS should announce the placeholder text provided at edit fields in command palette.
2 participants
@meganrogge @TylerLeonhardt