#165169 Move css rules from hover.ts into hover.css #166095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrieken Hi, is there any good way we can handle the transparency conversion of colors, for example:
|
Tyriar
requested changes
Nov 11, 2022
Tyriar
previously requested changes
Nov 11, 2022
|
Maybe we can use opacity |
|
For the workbench hover I just left the theme participant for transparent(0.5), opacity would change it and give the wrong effect. I think this is fine to keep that as is. |
get |
alexdima
approved these changes
Nov 16, 2022
lramos15
approved these changes
Nov 16, 2022
alexdima
dismissed
Tyriar’s stale review
Requested changes have been addressed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.