Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update electron@19.0.17 #161027

Merged
merged 4 commits into from
Sep 16, 2022
Merged

chore: update electron@19.0.17 #161027

merged 4 commits into from
Sep 16, 2022

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Sep 16, 2022

Fixes #157086
Fixes #150521
Fixes #160380
Fixes #155987

  • Update Utility Process API typings
  • Use process.parentPort and stdio feature

@deepak1556 deepak1556 self-assigned this Sep 16, 2022
@deepak1556 deepak1556 added this to the September 2022 milestone Sep 16, 2022
bpasero
bpasero previously approved these changes Sep 16, 2022
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@deepak1556
Copy link
Collaborator Author

Triggered product build https://monacotools.visualstudio.com/Monaco/_build/results?buildId=185485&view=results to run test suites with extension host as utility process.

@deepak1556 deepak1556 marked this pull request as ready for review September 16, 2022 07:00
@deepak1556 deepak1556 requested a review from alexdima September 16, 2022 07:05
@deepak1556
Copy link
Collaborator Author

Tests are looking good 🚀

@deepak1556 deepak1556 requested a review from bpasero September 16, 2022 07:40
bpasero
bpasero previously approved these changes Sep 16, 2022
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fluke?

image

@deepak1556
Copy link
Collaborator Author

Looking into it

@deepak1556
Copy link
Collaborator Author

Not a fluke, I had to enable some chromium components to get access to the Electron Helper (Plugin) executable on macOS which will help allowLoadingUnsignedLibraries option of utility process. This had introduced the libcups2 dependency, will address the change in this PR.

@deepak1556
Copy link
Collaborator Author

@bpasero bpasero self-requested a review September 16, 2022 09:36
@bpasero bpasero merged commit 22cbb8e into main Sep 16, 2022
@bpasero bpasero deleted the robo/update_electron branch September 16, 2022 10:41
@alexdima
Copy link
Member

👏

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants