-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Only resolve paths in REPL if path is relative #15794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@felixfbecker thanks a lot for your contributions! As for the monaco.d.ts errors, maybe try good old If running out of source does not work with these errors let me know and I will ask around for a solution for your issue. |
@felixfbecker did you succeed in runnning vscode out of source? |
Yes. I tested it, absolute paths work correct now. How can I get the node debugger in the OSS Dev build? Mocha always throws the relative paths, would like to test those |
@felixfbecker awesome! To get the node debugger in the oss dev build install it from the gallery, to enable the gallery in the oss dev build first add the following to the "extensionsGallery": {
"serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
"cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
"itemUrl": "https://marketplace.visualstudio.com/items"
} |
@felixfbecker let me know how this is working once you test those mocha relative paths - thanks! |
Awesome, let's merge this baby in. |
@felixfbecker we can not handle each and every case. This should improve once we start using the editor intead of the tree. Might investigate into that over Christmas |
Yeah I don't know how to handle it while still supporting spaces in paths (without matching the whole line by mistake).
I will come back to that offer 😄 |
Added back the root component capture to the regexp and call
toResource
conditionally. I would appreciate it if someone could check this out and test, still have trouble building, this is untested