Skip to content

Only resolve paths in REPL if path is relative #15794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2016

Conversation

felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Nov 21, 2016

Added back the root component capture to the regexp and call toResource conditionally. I would appreciate it if someone could check this out and test, still have trouble building, this is untested

@isidorn
Copy link
Contributor

isidorn commented Nov 22, 2016

@felixfbecker thanks a lot for your contributions!
The changes look good. Now let's try to fix your build issues.
From pr #15174 and looking at your original errors they all seem to be related to the generated monaco editor api file. I think we can just ignore those and still be able to run out of source with \scripts\code.bat. More details https://github.com/Microsoft/vscode/wiki/How-to-Contribute

As for the monaco.d.ts errors, maybe try good old git clean -fxd, and again scripts\npm install and gulp watch. Basically the monaco.d.ts file gets generate from monaco.d.ts.recipe and for some reason on your machine he is looking for other definition files which I do also do not have.

If running out of source does not work with these errors let me know and I will ask around for a solution for your issue.

@felixfbecker
Copy link
Contributor Author

Another bug
image

@isidorn
Copy link
Contributor

isidorn commented Nov 23, 2016

@felixfbecker did you succeed in runnning vscode out of source?

@felixfbecker
Copy link
Contributor Author

felixfbecker commented Nov 23, 2016

Yes. I tested it, absolute paths work correct now. How can I get the node debugger in the OSS Dev build? Mocha always throws the relative paths, would like to test those

@isidorn
Copy link
Contributor

isidorn commented Nov 24, 2016

@felixfbecker awesome! To get the node debugger in the oss dev build install it from the gallery, to enable the gallery in the oss dev build first add the following to the product.json before building the oss dev vscode. Let me know how it looks and if it seems good I will merge it in

"extensionsGallery": {
	"serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
	"cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
	"itemUrl": "https://marketplace.visualstudio.com/items"
}

@isidorn
Copy link
Contributor

isidorn commented Nov 25, 2016

@felixfbecker let me know how this is working once you test those mocha relative paths - thanks!

@felixfbecker
Copy link
Contributor Author

Just tested, works!

image

Side effect: the parens are underlined. No that much of a deal imo though

@felixfbecker
Copy link
Contributor Author

PHPUnit works:

image

@felixfbecker
Copy link
Contributor Author

Normal call stacks not unfortunately:

image

@isidorn
Copy link
Contributor

isidorn commented Nov 25, 2016

Awesome, let's merge this baby in.
You have a beer from me once you are in Zurich

@isidorn isidorn merged commit 027ff04 into microsoft:master Nov 25, 2016
@isidorn
Copy link
Contributor

isidorn commented Nov 25, 2016

@felixfbecker we can not handle each and every case. This should improve once we start using the editor intead of the tree. Might investigate into that over Christmas

@felixfbecker
Copy link
Contributor Author

Yeah I don't know how to handle it while still supporting spaces in paths (without matching the whole line by mistake).

You have a beer from me once you are in Zurich

I will come back to that offer 😄

@felixfbecker felixfbecker deleted the repl-links-fix branch June 7, 2017 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants