Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locale and include download count #156823

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Remove locale and include download count #156823

merged 2 commits into from
Aug 1, 2022

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Aug 1, 2022 •
edited
Loading

image
fixes #156254

@TylerLeonhardt TylerLeonhardt self-assigned this Aug 1, 2022
@vscodenpa vscodenpa added this to the August 2022 milestone Aug 1, 2022
mjbvz
mjbvz previously approved these changes Aug 1, 2022
View reviewed changes
rzhao271
rzhao271 reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precise count showing up looked odd to me, but I just realized that extensions do the same thing when I view an individual extension. However, in the extensions list view, I see shorter numbers like 21.4M instead. Can we reuse that?

@TylerLeonhardt
Copy link
Member Author

Thanks @rzhao271! I like that and because of that, I feel better about re-adding the locale which is something I wanted to keep in but removed since it looked cluttered. I think this looks good:
image

rzhao271
rzhao271 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also that branch name tho

@TylerLeonhardt TylerLeonhardt merged commit 6f8b946 into main Aug 1, 2022
@TylerLeonhardt TylerLeonhardt deleted the tyler/progressive-bedbug branch August 1, 2022 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@mjbvz mjbvz mjbvz left review comments

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
August 2022
Development

Successfully merging this pull request may close these issues.

Sorting of languages in picker
4 participants
@TylerLeonhardt @rzhao271 @mjbvz @vscodenpa