Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop in CodeAction Menu w/List Widget #152913 #155666

Merged
merged 38 commits into from
Jul 20, 2022

Conversation

justschen
Copy link
Contributor

Implements #152913.

Currently under experimental setting (Editor › Contrib › Experimental › Code Action Widget)

Has some minor issues with some specific color themes.

Justin Chen and others added 30 commits June 28, 2022 09:49
@justschen justschen requested a review from mjbvz July 19, 2022 23:16
@vscodenpa vscodenpa added this to the July 2022 milestone Jul 19, 2022
@justschen
Copy link
Contributor Author

Currently also has an odd bug when turning on and off the experimental setting where the first item in the list will not be highlighted.

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a first look through! Looks like things are going in the right direction but some parts need a little polishing up

Let me know if you have any questions about the comments

@justschen justschen requested a review from mjbvz July 20, 2022 21:33
@justschen justschen merged commit 3f454e9 into microsoft:main Jul 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants