fix: compilation of vscode-encrypt for darwin arm64 #154762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for verification: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=177589&view=results |
deepak1556
force-pushed
the
robo/fix_nm_build
branch
from
63b4dd5
to
3ef6d10
Compare
|
Openssl is built for the wrong architecture in CI due to cross compilation |
deepak1556
force-pushed
the
robo/fix_nm_build
branch
from
c6cec2a
to
e2f7276
Compare
deepak1556
changed the title
|
Verified with
|
joaomoreno
approved these changes
Jul 12, 2022
|
@deepak1556 Curious why this fix was made only for the I'm definitely seeing this keychain issue across both macOS builds on macOS Ventura, but I also have no idea when this fix will go live with a new insiders build, or if it should even be affecting the universal builds or not. |
|
Fix for arm64 also addresses the issue for universal, the fix will be be available with tomorrow's insider. |
andreamah
pushed a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Insiders still ships a broken version of the
vscode-encryptnative module for macOS arm64,From local build of latest
vscode-encrypt% nm -g ./build/Release/vscode-encrypt-native.node | grep _openssl_fopen 00000000000dc740 T _openssl_fopenFixes #152964
/cc @TylerLeonhardt