Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook kernel source menu contribution #150146

Merged
merged 14 commits into from
May 24, 2022
Merged

Notebook kernel source menu contribution #150146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7e34708
prepare for removing proxy kernel.
rebornix May 11, 2022
027b7bf
Notebook state only.
rebornix May 16, 2022
bd99c99
Remove proxy controller.
rebornix May 16, 2022
6403027
remove main thread proxy kenrel
rebornix May 16, 2022
95b8607
load source commands
rebornix May 18, 2022
9d49470
Merge remote-tracking branch 'origin/main' into rebornix/controller-c…
rebornix May 20, 2022
2796b34
Allow single source action to be executed without picking
rebornix May 20, 2022
8d503ff
connection state in another pr
rebornix May 20, 2022
50d802e
:lipstick:
rebornix May 20, 2022
17f17b4
remove remaining kernel state.
rebornix May 23, 2022
cb30029
show install from marketplace only when there is no kernels and comma…
rebornix May 23, 2022
01e4dbd
hide explicit IAction.
rebornix May 23, 2022
11d269d
update tests
rebornix May 24, 2022
568d036
shim for menu service in more tests.
rebornix May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove remaining kernel state.
  • Loading branch information
@rebornix
rebornix committed May 23, 2022
commit 17f17b429b44b55e158913159fc06279921a23e4
10 changes: 0 additions & 10 deletions src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelActionViewItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import 'vs/css!./notebookKernelActionViewItem';
import { ActionViewItem } from 'vs/base/browser/ui/actionbar/actionViewItems';
import { Action, IAction } from 'vs/base/common/actions';
import { DisposableStore } from 'vs/base/common/lifecycle';
import { localize } from 'vs/nls';
import { ThemeIcon } from 'vs/platform/theme/common/themeService';
import { executingStateIcon, selectKernelIcon } from 'vs/workbench/contrib/notebook/browser/notebookIcons';
Expand All @@ -18,7 +17,6 @@ import { INotebookEditor } from 'vs/workbench/contrib/notebook/browser/notebookB
export class NotebooKernelActionViewItem extends ActionViewItem {

private _kernelLabel?: HTMLAnchorElement;
private _kernelDisposable: DisposableStore;

constructor(
actualAction: IAction,
Expand All @@ -34,7 +32,6 @@ export class NotebooKernelActionViewItem extends ActionViewItem {
this._register(_notebookKernelService.onDidChangeNotebookAffinity(this._update, this));
this._register(_notebookKernelService.onDidChangeSelectedNotebooks(this._update, this));
this._register(_notebookKernelService.onDidChangeSourceActions(this._update, this));
this._kernelDisposable = this._register(new DisposableStore());
}

override render(container: HTMLElement): void {
Expand Down Expand Up @@ -96,7 +93,6 @@ export class NotebooKernelActionViewItem extends ActionViewItem {
}

private _updateActionFromKernelInfo(info: INotebookKernelMatchResult): void {
this._kernelDisposable.clear();
this._action.enabled = true;
this._action.class = ThemeIcon.asClassName(selectKernelIcon);
const selectedOrSuggested = info.selected ?? (info.suggestions.length === 1 ? info.suggestions[0] : undefined);
Expand All @@ -107,12 +103,6 @@ export class NotebooKernelActionViewItem extends ActionViewItem {
if (!info.selected) {
// special UI for selected kernel?
}

this._kernelDisposable.add(selectedOrSuggested.onDidChange(e => {
if (e.state) {
this._action.label = this._generateKenrelLabel(selectedOrSuggested);
}
}));
} else {
// many kernels or no kernels
this._action.label = localize('select', "Select Kernel");
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/services/actions/common/menusExtensionPoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const apiMenus: IAPIMenu[] = [
key: 'notebook/kernelSource',
id: MenuId.NotebookKernelSource,
description: localize('notebook.kernelSource', "The contributed notebook kernel sources menu"),
proposed: 'notebookProxyController'
proposed: 'notebookKernelSource'
},
{
key: 'notebook/cell/title',
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/services/extensions/common/extensionsApiProposals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ export const allApiProposals = Object.freeze({
notebookEditor: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditor.d.ts',
notebookEditorDecorationType: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditorDecorationType.d.ts',
notebookEditorEdit: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditorEdit.d.ts',
notebookKernelSource: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookKernelSource.d.ts',
notebookLiveShare: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookLiveShare.d.ts',
notebookMessaging: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookMessaging.d.ts',
notebookMime: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookMime.d.ts',
notebookProxyController: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookProxyController.d.ts',
notebookWorkspaceEdit: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookWorkspaceEdit.d.ts',
portsAttributes: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.portsAttributes.d.ts',
quickPickSortByLabel: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.quickPickSortByLabel.d.ts',
Expand Down
0 ...ode.proposed.notebookProxyController.d.ts → ...vscode.proposed.notebookKernelSource.d.ts
View file
Open in desktop
File renamed without changes.