Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding gdpr comments for owned events #148595

Merged
merged 1 commit into from
May 2, 2022
Merged

adding gdpr comments for owned events #148595

merged 1 commit into from
May 2, 2022

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented May 2, 2022

ATTR: 5 minutes

@sbatten sbatten self-assigned this May 2, 2022
@sbatten sbatten added this to the May 2022 milestone May 2, 2022
@sbatten sbatten requested a review from lramos15 May 2, 2022 22:44
lramos15
lramos15 approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit about still using old __GDPR__ comment. Would be interested to see if we can convert it as it doesn't seem to be a wild card or anything unsupported at first glance. Otherwise thanks for making the change!

@sbatten sbatten merged commit a164020 into main May 2, 2022
@sbatten sbatten deleted the sbatten/gdprcomments branch May 2, 2022 23:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@sbatten @lramos15